Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Editor: Include reusable blocks in announced inserter search results #22279

Merged
merged 5 commits into from
May 12, 2020
Merged

Block Editor: Include reusable blocks in announced inserter search results #22279

merged 5 commits into from
May 12, 2020

Conversation

aduth
Copy link
Member

@aduth aduth commented May 11, 2020

Related: https://github.com/WordPress/gutenberg/pull/10755/files#r423267328

This pull request seeks to resolve an issue where searching for a block in the block inserter would not count reusable blocks in the spoken message of search results. It also serves as a minor refactoring to simplify the logic involved in determining this count, using the direct result of filteredItems array instead of recomputing an aggregate sum of itemsPerCategory (which notably omits reusable blocks).

Before After
before after

Testing Instructions:

Verify block inserter search results announcement accounts for reusable block search results.

  1. Navigate to Posts > Add New
  2. (Prerequisite) Create a reusable block, if you don't already have one available
  3. Toggle the block inserter
  4. (Prerequisite) Turn on some form of screen reader (Cmd+F5 in macOS for VoiceOver) if not already enabled
  5. Search for the reusable block
  6. Note that the result is accounted for in the announced "X results found." message

Ensure unit tests pass:

npm run test-unit packages/block-editor/src/components/inserter/test/block-list.js

@aduth aduth added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Package] Block editor /packages/block-editor labels May 11, 2020
This was referenced May 11, 2020
Merged
Merged
@github-actions
Copy link

github-actions bot commented May 11, 2020 •
edited
Loading

Size Change: +2.53 kB (0%)

Total Size: 827 kB

Filename Size Change
build/block-directory/index.js 6.62 kB +3 B (0%)
build/block-directory/style-rtl.css 764 B +4 B (0%)
build/block-directory/style.css 764 B +3 B (0%)
build/block-editor/index.js 104 kB +1.42 kB (1%)
build/block-editor/style-rtl.css 10.6 kB +257 B (2%)
build/block-editor/style.css 10.6 kB +253 B (2%)
build/block-library/index.js 115 kB +6 B (0%)
build/blocks/index.js 48.1 kB -1 B
build/components/index.js 181 kB +591 B (0%)
build/compose/index.js 6.66 kB -1 B
build/data/index.js 8.43 kB -13 B (0%)
build/edit-navigation/index.js 4.42 kB +9 B (0%)
build/edit-post/index.js 28 kB +2 B (0%)
build/edit-site/index.js 12.1 kB -1 B
build/edit-widgets/index.js 8.37 kB +3 B (0%)
build/element/index.js 4.65 kB -2 B (0%)
build/format-library/index.js 7.63 kB -1 B
build/plugins/index.js 2.56 kB -1 B
build/rich-text/index.js 14.8 kB -1 B
build/viewport/index.js 1.84 kB +1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.02 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/api-fetch/index.js 4.08 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-library/editor-rtl.css 7.12 kB 0 B
build/block-library/editor.css 7.12 kB 0 B
build/block-library/style-rtl.css 7.38 kB 0 B
build/block-library/style.css 7.38 kB 0 B
build/block-library/theme-rtl.css 683 B 0 B
build/block-library/theme.css 685 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/components/style-rtl.css 17 kB 0 B
build/components/style.css 16.9 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.1 kB 0 B
build/edit-navigation/style-rtl.css 618 B 0 B
build/edit-navigation/style.css 617 B 0 B
build/edit-post/style-rtl.css 12.2 kB 0 B
build/edit-post/style.css 12.2 kB 0 B
build/edit-site/style-rtl.css 5.22 kB 0 B
build/edit-site/style.css 5.22 kB 0 B
build/edit-widgets/style-rtl.css 4.69 kB 0 B
build/edit-widgets/style.css 4.69 kB 0 B
build/editor/editor-styles-rtl.css 425 B 0 B
build/editor/editor-styles.css 428 B 0 B
build/editor/index.js 44.3 kB 0 B
build/editor/style-rtl.css 5.07 kB 0 B
build/editor/style.css 5.08 kB 0 B
build/escape-html/index.js 734 B 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 2.14 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.51 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 5.29 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/server-side-render/index.js 2.68 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.02 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@aduth
Copy link
Member Author

aduth commented May 11, 2020

Adding label "Needs Accessibility Feedback" in regards to my comment at #22279 (comment).

@aduth aduth added the Needs Accessibility Feedback Need input from accessibility label May 11, 2020
@aduth aduth mentioned this pull request May 11, 2020
Merged
2 tasks
youknowriad
youknowriad approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good. Would be good to have a confirmation about the deps.

@aduth aduth removed the Needs Accessibility Feedback Need input from accessibility label May 12, 2020
@aduth aduth merged commit 89e21cf into master May 12, 2020
@aduth aduth deleted the fix/inserter-filtered-reusable-speak branch May 12, 2020 19:33
@github-actions github-actions bot added this to the Gutenberg 8.2 milestone May 12, 2020
@aduth aduth mentioned this pull request May 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afercia afercia afercia left review comments

@youknowriad youknowriad youknowriad approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

Assignees
No one assigned
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 8.2
Development

Successfully merging this pull request may close these issues.
3 participants
@aduth @youknowriad @afercia